Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #953

Merged
merged 7 commits into from May 19, 2023
Merged

Update workflows #953

merged 7 commits into from May 19, 2023

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented May 13, 2023

1239124 changed to use std::from_chars from C++17. Unfortunately LLVM's libc++ does not yet implement std::from_chars for float and double. Hence it breaks compilation on Clang/LLVM with libc++.

@Setsugennoao
Copy link
Contributor

Why does this PR mix workflow, typos, and PresetVideoFormat?

@Setsugennoao
Copy link
Contributor

Can you also rename the struct in the docs?

@myrsloik
Copy link
Member

Will merge if you split it out into ONLY the workflow bits

The ubuntu-latest label currently uses the Ubuntu 22.04 runner image.
GCC 12 is already preinstalled on the runner.

Also only use GCC 12 for building test.
PKG_CONFIG_PATH environment variable is set since v4, so manual setting is unnecessary now.
@HolyWu HolyWu changed the title Fix all failed workflows...except macOS Update workflows May 19, 2023
@HolyWu
Copy link
Contributor Author

HolyWu commented May 19, 2023

Done.

@myrsloik myrsloik merged commit f5a443b into vapoursynth:master May 19, 2023
8 of 10 checks passed
vishwin pushed a commit to vishwin/freebsd-ports that referenced this pull request Aug 5, 2023
* Plugins are no longer maintained within the main project repo
* Revert upstream commit 1239124c2d70f32c468326e48bfa7e9362550c36
  as it breaks compatibility with Clang/LLVM with libc++ [1]

1: vapoursynth/vapoursynth#953

Changelog: https://github.com/vapoursynth/vapoursynth/releases/tag/R63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants