Improve accesibility via adding aria-label to the switch input #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been updated a long time ago after the default app template rewrite. Whoops!
This will allow users using the beta to visit the link in their deprecation warning messages.
bitspittle
force-pushed
the
main
branch
2 times, most recently
from
cce8758
to
7215db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an accessibility issue identified using the Lighthouse tool. The problem occurs due to the Switch Component lacking a proper label that describes the input used as a switch.
To resolve this, I added the modifier
arialLabelto the Input Component. This solution I get it from here aria-label accesibilityYou can see similar problems discussed in the following links:
Deque University: Accessibility Rule - Ensure every form element has a label