Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icicle/Flame view doesn't capture the right canvas height on some machine #12

Closed
shawncao opened this issue Nov 2, 2020 · 2 comments · Fixed by #23
Closed

Icicle/Flame view doesn't capture the right canvas height on some machine #12

shawncao opened this issue Nov 2, 2020 · 2 comments · Fixed by #23
Labels
bug Something isn't working

Comments

@shawncao
Copy link
Collaborator

shawncao commented Nov 2, 2020

I found the same view has incorrect height on my laptop while it is okay showing on a dell monitor.

Also - the main color for icicle/flame is too dark (dark red), not good for this visual, should do some adjustment on it.
@shawncao
Copy link
Collaborator Author

shawncao commented Nov 2, 2020

This is correct on a dell monitor:
Screen Shot 2020-11-02 at 10 29 18 AM

This is incorrect on my laptop:
Screen Shot 2020-11-02 at 10 29 36 AM

@shawncao shawncao added the bug Something isn't working label Nov 18, 2020
@shawncao
Copy link
Collaborator Author

this should be fixed by latest PR #23

@shawncao shawncao linked a pull request Nov 24, 2020 that will close this issue
Remove display from query #23
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove display from query varchar-io/nebula
1 participant
@shawncao