Skip to content

Commit

Permalink
Form template reports error if genomebuild variable is not set. (#609)
Browse files Browse the repository at this point in the history
Closes: #607
Related-Issue: #607
Projected-Results-Impact: none
  • Loading branch information
stolpeo committed Aug 4, 2022
1 parent 2cc6607 commit 25ba9c1
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 8 deletions.
5 changes: 3 additions & 2 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,18 @@ End-User Summary
- Add Transcripts GnomadAD constraints and clinvar reports in the export(#568)
- Extra annotations in export completed and tested (#495).
- Fixed bug where Exac and thousand genomes settings were not shown in frequency tab for GRCh37 (#597).
- Form template reports error if genomebuild variable is not set (#607).

Full Change List
================

- Extra annotations in export completed and tested (#495).
- Fixing issue with sync-from-remote when no remote is defined (#570).
- Fixed bug where Exac and thousand genomes settings were not shown in frequency tab for GRCh37 (#597).

- Form template reports error if genomebuild variable is not set (#607).

-----------------
v1.2.2 (anthenea)
v1.2.1 (anthenea)
-----------------

End-User Summary
Expand Down
32 changes: 26 additions & 6 deletions variants/templates/variants/filter_form/frequency.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,16 @@
The checkboxes enable (<i class="iconify" data-icon="fa-regular:check-square"></i>) or disable (<i class="iconify" data-icon="fa-regular:square"></i>) filtration based on the population frequencies of the given database.
You can provide the number of carriers with maximal heterozygous/homozygous (respectively: -plasmid) state or population frequencies.
For the in-house DB, you can only filter based on carrier state as currently it is tracked how many carriers have sufficient coverage for each variant.
{% if genomebuild != "GRCh37" %}Thousand genomes and ExAC frequencies are only available GRCh37 cases.{% endif %}
{% if genomebuild == "GRCh37" %}
{% elif genomebuild == "GRCh38" %}
Thousand genomes and ExAC frequencies are only available GRCh37 cases.
{% else %}
<div class="alert alert-danger">
<i class="iconify" data-icon="bi:exclamation-circle"></i>
Genomebuild variable is unknown (<strong>{{ genomebuild }}</strong>).
The form might not be displayed correctly.
</div>
{% endif %}
</div>

<table class="table table-striped table-hover sodar-card-table compact-form-groups">
Expand All @@ -24,18 +33,29 @@
</tr>
</thead>
<tbody>
<tr>
<td colspan="6">{{ genomebuild }}</td>
</tr>
<tr{% if genomebuild != "GRCh37" %} style="display: none;"{% endif %}>
<tr
{% if genomebuild == "GRCh37" %}
{% elif genomebuild == "GRCh38" %}
style="display: none;"
{% else %}
class="text-danger"
{% endif %}
>
<td>{{ form.thousand_genomes_enabled|as_crispy_field }}</td>
<td data-toggle="tooltip" title="Phase 3 data (healthy individuals)">1000 Genomes <small class="text-muted">(samples: 1000)</small></td>
<td>{{ form.thousand_genomes_homozygous|as_crispy_field }}</td>
<td>{{ form.thousand_genomes_heterozygous|as_crispy_field }}</td>
<td>{{ form.thousand_genomes_hemizygous|as_crispy_field }}</td>
<td>{{ form.thousand_genomes_frequency|as_crispy_field }}</td>
</tr>
<tr{% if genomebuild != "GRCh37" %} style="display: none;"{% endif %}>
<tr
{% if genomebuild == "GRCh37" %}
{% elif genomebuild == "GRCh38" %}
style="display: none;"
{% else %}
class="text-danger"
{% endif %}
>
<td>{{ form.exac_enabled|as_crispy_field }}</td>
<td data-toggle="tooltip" title="Exomes; project attempts to exclude pediatric disease cases">ExAC <small class="text-muted">(samples: 60,706)</small></td>
<td>{{ form.exac_homozygous|as_crispy_field }}</td>
Expand Down

0 comments on commit 25ba9c1

Please sign in to comment.