Allowing project owners and delegates to import cases via API (#207).

varfish-org · Nov 29, 2021 · 360c24b · 360c24b
1 parent cf0909d
commit 360c24b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -17,6 +17,7 @@ End-User Summary
 - Fixed recompute of variant stats of large small variant sets.
 - Added index for ``SmallVariant`` model filtering for ``case_id`` and ``set_id``.
   This may take a while!
+- Allowing project owners and delegates to import cases via API (#207).
 
 Full Change List
 ================
@@ -33,6 +34,7 @@ Full Change List
 - Fixed recompute of variant stats of large small variant sets.
 - Added index for ``SmallVariant`` model filtering for ``case_id`` and ``set_id``.
   This may take a while!
+- Allowing project owners and delegates to import cases via API (#207).
 
 -------
 v0.23.9

diff --git a/importer/rules.py b/importer/rules.py
@@ -12,18 +12,20 @@
 
 # Rules ------------------------------------------------------------------------
 
-
-rules.add_perm(
-    "importer.view_import",
+is_allowed_to_modify = (
     rules.is_superuser
     | pr_rules.is_project_owner
     | pr_rules.is_project_delegate
-    | pr_rules.is_project_contributor,
+    | pr_rules.is_project_contributor
+)
+
+rules.add_perm(
+    "importer.view_import", is_allowed_to_modify,
 )
 
-rules.add_perm("importer.add_import", rules.is_superuser | pr_rules.is_project_contributor)
-rules.add_perm("importer.delete_import", rules.is_superuser | pr_rules.is_project_contributor)
-rules.add_perm("importer.update_import", rules.is_superuser | pr_rules.is_project_contributor)
+rules.add_perm("importer.add_import", is_allowed_to_modify)
+rules.add_perm("importer.delete_import", is_allowed_to_modify)
+rules.add_perm("importer.update_import", is_allowed_to_modify)
 
 # Permissions ------------------------------------------------------------------