Fix issue with variant annotation export (#328)

varfish-org · Feb 2, 2022 · 7c2012a · 7c2012a
1 parent afb0144
commit 7c2012a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -43,6 +43,7 @@ End-User Summary
 - Make clinvar UI work with many annotations (#302)
 - Fixing CADD annotation (#319)
 - Adding mitochondrial inheritance to case phenotype annotation (#325)
+- Fix issue with variant annotation export (#328)
 
 Full Change List
 ================
@@ -89,6 +90,7 @@ Full Change List
   Dropping support for Python 3.7.
 - Fixing CADD annotation (#319)
 - Adding mitochondrial inheritance to case phenotype annotation (#325)
+- Fix issue with variant annotation export (#328)
 
 -------
 v0.23.9

diff --git a/variants/views.py b/variants/views.py
@@ -1554,10 +1554,14 @@ def yield_rows(self, *, case, cases, project):
                     x.refseq_transcript_id for x in anno["variants"] if x.refseq_gene_id
                 )
                 hgvs = ", ".join(
-                    x.refseq_hgvs_p or x.refseq_hgvs_c for x in anno["variants"] if x.refseq_gene_id
+                    x.refseq_hgvs_p or x.refseq_hgvs_c
+                    for x in anno["variants"]
+                    if x.refseq_gene_id and (x.refseq_hgvs_p or x.refseq_hgvs_c)
                 )
                 effects = ", ".join(
-                    "&".join(x.refseq_effect) for x in anno["variants"] if x.refseq_gene_id
+                    "&".join(x.refseq_effect)
+                    for x in anno["variants"]
+                    if x.refseq_gene_id and x.refseq_effect
                 )
 
                 variant = anno["variants"][0]