Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying the case list for large projects is slow #304

Closed
holtgrewe opened this issue Jan 29, 2022 · 3 comments
Closed

Displaying the case list for large projects is slow #304

holtgrewe opened this issue Jan 29, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@holtgrewe
Copy link
Collaborator

holtgrewe commented Jan 29, 2022

Describe the bug
It is very slow to open the list of all cases for many projects.

To Reproduce
Steps to reproduce the behavior:

  1. Open the case list for a project with many cases.
  2. See the page load for many seconds.

Expected behavior
The page list should be faster or we have to add pagination to make it faster.

Screenshots
N/A

Additional context

@holtgrewe
Copy link
Collaborator Author

holtgrewe commented Jan 29, 2022

Root Cause Analysis

  • look at all queries generated by project overview
  • there are 10k+ annotated variants which explains the problem (all of them are fetched, chrome developer tools shows 46MB of data)
  • previously, we only had one web server thread, now there are more so things can actually load in the background
  • after the tab with the annotated variant has loaded, the tab actually gets overloaded
  • further, the QC data for such big projects is huge (e.g., chrome developer tools show 70MB of data for QC)

@holtgrewe
Copy link
Collaborator Author

holtgrewe commented Jan 29, 2022

Resolution Proposal

  • only load quality control and annotation table when the tab is actually opened
  • refuse to display variant annoation as HTML for more than 100 variants
  • load quality control figures only when user explicitely clicks button
  • document this to the user as a known issue

Note that this is only a mitigation, the problem will be corrected properly in follow-up issues.

Affected Components

  • varfish-server

Affected Modules/Files

  • variants modules with urls, views, templates

Required Architectural Changes
N/A

Resolution Sketch

  • use more lazy loading of tabs
  • add button to load QC explicitely

@holtgrewe
Copy link
Collaborator Author

Whoops, flipped #303 and #304 here. Moving text to #303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant