Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variant annotation update in case overview #344

Closed
holtgrewe opened this issue Feb 8, 2022 · 1 comment · Fixed by #350
Closed

Allow variant annotation update in case overview #344

holtgrewe opened this issue Feb 8, 2022 · 1 comment · Fixed by #350
Assignees
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Collaborator

holtgrewe commented Feb 8, 2022

Is your feature request related to a problem? Please describe.
It is very tedious to update already annotated variants: lookup in variant overview, get a search result that includes them, update them in the results table.

Describe the solution you'd like
We need controls to update the variant in the case overview screen (Variant Annotation tab in /variants/{project}/case/{case}/).

Describe alternatives you've considered
N/A

Additional context
N/A

@holtgrewe holtgrewe added the enhancement New feature or request label Feb 8, 2022
@holtgrewe
Copy link
Collaborator Author

Implementation Proposal
Add buttons to the case variant annotation overview that allow to variant annotation updates in this screen. Ideally, show the forms in modals. Saving the variant should trigger a reload of the variant annotation tab. Reuse as many existing APIs as possible.

Affected Components

  • VarFish Server only

Affected Modules/Files

  • variants/templates/variants/case/detail_annotation.html

Required Architectural Changes

  • None

Implementation Sketch

  • Add buttons and modal to HTML
  • Add Javascript for the code
  • Add tests

@holtgrewe holtgrewe self-assigned this Feb 8, 2022
@holtgrewe holtgrewe added this to the athenea-1.1.0 (RC) milestone Feb 8, 2022
@holtgrewe holtgrewe assigned stolpeo and unassigned holtgrewe Feb 8, 2022
stolpeo pushed a commit that referenced this issue Feb 9, 2022
Adding deep linking into case details tab (#344)
Intermediate. Instant flag update and tests are missing.
stolpeo pushed a commit that referenced this issue Feb 9, 2022
Adding deep linking into case details tab (#344)
Intermediate. Instant flag update and tests are missing.
stolpeo pushed a commit that referenced this issue Feb 9, 2022
Adding deep linking into case details tab (#344)
Intermediate. Instant flag update and tests are missing.
stolpeo pushed a commit that referenced this issue Feb 9, 2022
Adding deep linking into case details tab (#344)
Intermediate. Instant flag update and tests are missing.
stolpeo added a commit that referenced this issue Feb 10, 2022
…ions details (#344, #348) (#350)

Co-authored-by: Manuel Holtgrewe <manuel.holtgrewe@bihealth.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants