Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo mode does not display welcoming page #458

Closed
stolpeo opened this issue Apr 26, 2022 · 3 comments
Closed

Demo mode does not display welcoming page #458

stolpeo opened this issue Apr 26, 2022 · 3 comments
Labels
bug Something isn't working
Milestone
bollonaster-2.0.0...

Comments

@stolpeo
Copy link
Contributor

stolpeo commented Apr 26, 2022

Describe the bug
VarFish demo mode (varfish-demo.bihealth.org) does not display the welcoming page created for the demo mode but the common login mask.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://varfish-demo.bihealth.org
  2. See error

Expected behavior
Display the welcoming page in demo mode:

Login as user demouser with password varfishdemo. This site hosts data from the public domain (thousand genomes project) for demonstration purposes. For protection against vandalism, all user-entered data will be cleared nightly (Berlin time).

If you want to upload your data, then have a look at varfish-kiosk.bihealth.org. Consult the manual on how to create your own VarFish installation.
@stolpeo stolpeo added the bug Something isn't working label Apr 26, 2022
@holtgrewe holtgrewe added this to the bollonaster-2.0.0 (dev) milestone Apr 26, 2022
@holtgrewe
Copy link
Collaborator

holtgrewe commented Apr 26, 2022 •
edited

Root Cause Analysis
We used the default login template from sodar-core when upgrading.

@holtgrewe
Copy link
Collaborator

Resolution Proposal
Replace the login page template by something that interprets the VARFISH_LOGIN_PAGE_TEXT setting again.

Affected Components
VarFish Server

Affected Modules/Files
varfish/templates/users/login.html

Required Architectural Changes
None

Resolution Sketch
Port the older code of the login.html template that interprets the VARFISH_LOGIN_PAGE_TEXT setting.

@holtgrewe
Copy link
Collaborator

This should also be backported to the athenea branch.

holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Displaying login page text from settings again (#458)
d50e255 
Related-Issue: #458
Closes: #458
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Displaying login page text from settings again (#458)
a77d3b4 
Related-Issue: #458
Closes: #458
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Displaying login page text from settings again (#458)
2477e67 
Related-Issue: #458
Closes: #458
Projected-Results-Impact: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
bollonaster-2.0.0 (dev)
Development

No branches or pull requests
2 participants
@holtgrewe @stolpeo