Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login does not work when @ character is part of user name #459

Closed
holtgrewe opened this issue Apr 26, 2022 · 3 comments · Fixed by #460
Closed

Login does not work when @ character is part of user name #459

holtgrewe opened this issue Apr 26, 2022 · 3 comments · Fixed by #460
Labels
bug Something isn't working
Milestone
bollonaster-2.0.0...

Comments

@holtgrewe
Copy link
Collaborator

Describe the bug
When user names contain an @ character then login does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Go to varfish-demo
  2. Enter user@madascar
  3. See that it is replaced by user@MDC-BERLIN
  4. Login does not work

Expected behavior
The user name should remain user@madagascar

Additional context
Either varfish oder sodar-core have the auto-replacement behaviour of SODAR which replaces @c by @CHARITE and @m by @MDC-BERLIN in user names on login.
@holtgrewe holtgrewe added the bug Something isn't working label Apr 26, 2022
@holtgrewe holtgrewe added this to the bollonaster-2.0.0 (dev) milestone Apr 26, 2022
@holtgrewe
Copy link
Collaborator Author

Root Cause Analysis
We copied over the file varfish/static/js/login.js from SODAR to VarFish.

@holtgrewe
Copy link
Collaborator Author

Resolution Proposal
For now, we should just remove the problematic code. This comes at the cost of the auto-fill not working any more.

Affected Components
VarFish Server

Affected Modules/Files
varfish/static/js/login.js

Required Architectural Changes
None

Resolution Sketch

  • Make the varfish/static/js/login.js file empty.

@holtgrewe
Copy link
Collaborator Author

This should be backported to the athenea branch.

holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Removing username modification behaviour on login page (#459)
5b28aec 
Related-Issue: #459
Closes: #459
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Removing username modification behaviour on login page (#459)
382b7f9 
Related-Issue: #459
Closes: #459
Projected-Results-Impact: none
@holtgrewe holtgrewe linked a pull request Apr 26, 2022 that will close this issue
459 login does not work when character is part of user name #460
Merged
holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Removing username modification behaviour on login page (#459)
5d8a417 
Related-Issue: #459
Closes: #459
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Apr 26, 2022
@holtgrewe
Removing username modification behaviour on login page (#459)
691668a 
Related-Issue: #459
Closes: #459
Projected-Results-Impact: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
bollonaster-2.0.0 (dev)
Development

Successfully merging a pull request may close this issue.

459 login does not work when character is part of user name varfish-org/varfish-server
1 participant
@holtgrewe