-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thousand genomes allele count not applied for SVs #619
Labels
bug
Something isn't working
Comments
Root Cause Analysis
|
Resolution Proposal Affected Components Affected Modules/Files Required Architectural Changes Required Database Changes Backport Possible? Resolution Sketch diff --git a/svs/queries.py b/svs/queries.py
index 95e5bb2..a966291 100644
--- a/svs/queries.py
+++ b/svs/queries.py
@@ -385,6 +385,7 @@ class ExtendQueryPartsPublicDatabaseFrequencyJoinAndFilter(ExtendQueryPartsBase)
def extend_conditions(self, _query_parts):
result = []
for token, _, _ in self.TOKEN_MODEL_FIELD:
+ entity = "alleles" if token == "g1k" else "carriers"
if (
self.kwargs.get("%s_enabled" % token, False)
and ("%s_overlap_count" % token) in self.fields
@@ -392,7 +393,7 @@ class ExtendQueryPartsPublicDatabaseFrequencyJoinAndFilter(ExtendQueryPartsBase)
):
result.append(
self.fields["%s_overlap_count" % token]
- <= self.kwargs["%s_max_carriers" % token]
+ <= self.kwargs["%s_max_%s" % (token, entity)]
)
return result
|
holtgrewe
added a commit
that referenced
this issue
Aug 25, 2022
holtgrewe
added a commit
that referenced
this issue
Aug 25, 2022
holtgrewe
added a commit
that referenced
this issue
Aug 25, 2022
holtgrewe
added a commit
that referenced
this issue
Aug 26, 2022
holtgrewe
added a commit
that referenced
this issue
Aug 29, 2022
holtgrewe
added a commit
that referenced
this issue
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The allele count for SVs appears to be not applied for SVs.
To Reproduce
Steps to reproduce the behavior:
10
Expected behavior
Such variants should be removed by the filter.
Screenshots
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: