Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if more than max row count rows are returned #641

Closed
holtgrewe opened this issue Aug 30, 2022 · 2 comments · Fixed by #642
Closed

Warn if more than max row count rows are returned #641

holtgrewe opened this issue Aug 30, 2022 · 2 comments · Fixed by #642
Labels
enhancement New feature or request
Milestone
bollonaster-2.0.0...

Comments

@holtgrewe
Copy link
Collaborator

holtgrewe commented Aug 30, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
The maximal variant display count of 200 is quite stringent. It is easy to overlook that variants are cut off.

Describe the solution you'd like
We should display a more verbose warning in a red box if the variant count is cut off.

Describe alternatives you've considered
N/A

Additional context
N/A
@holtgrewe holtgrewe added the enhancement New feature or request label Aug 30, 2022
@holtgrewe holtgrewe added this to the bollonaster-2.0.0 (dev) milestone Aug 30, 2022
@holtgrewe
Copy link
Collaborator Author

holtgrewe commented Aug 30, 2022 •
edited
Loading

Resolution Proposal
Implement settings defaults change and add the box to the display.

Affected Components
VarFish server

Affected Modules/Files
variants/templates/*

Required Architectural Changes
None

Required Database Changes
None

Backport Possible?
Yes

Resolution Sketch

  • adjust template with warning box

@holtgrewe holtgrewe changed the title Adjust setting: maximal variants to display to 1000 Warn if more than max row count rows are returne Aug 30, 2022
@holtgrewe holtgrewe changed the title Warn if more than max row count rows are returne Warn if more than max row count rows are returned Aug 30, 2022
@holtgrewe
Copy link
Collaborator Author

I'm deciding on leaving the settings as is and just display a verbose box on top in case of truncation.

holtgrewe added a commit that referenced this issue Aug 30, 2022
@holtgrewe
Warning in case of truncated display (#641).
6eeb117 
Related-Issue: #641
Closes: #641
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Aug 30, 2022
@holtgrewe
Warning in case of truncated display (#641).
8d74162 
Related-Issue: #641
Closes: #641
Projected-Results-Impact: none
@holtgrewe holtgrewe linked a pull request Aug 30, 2022 that will close this issue
641 adjust setting maximal variants to display to 1000 #642
Merged
@holtgrewe holtgrewe mentioned this issue Aug 30, 2022
Merged
holtgrewe added a commit that referenced this issue Aug 30, 2022
@holtgrewe
Warning in case of truncated display (#641).
210d669 
Related-Issue: #641
Closes: #641
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Aug 30, 2022
@holtgrewe
Warning in case of truncated display (#641).
19ca149 
Related-Issue: #641
Closes: #641
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Sep 6, 2022
@holtgrewe
Warning in case of truncated display (#641).
e98d2d4 
Related-Issue: #641
Closes: #641
Projected-Results-Impact: none
holtgrewe added a commit that referenced this issue Sep 7, 2022
@holtgrewe
Warning in case of truncated display (#641).
8ceceac 
Related-Issue: #641
Closes: #641
Projected-Results-Impact: none
@holtgrewe holtgrewe mentioned this issue Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
bollonaster-2.0.0 (dev)
Development

Successfully merging a pull request may close this issue.

641 adjust setting maximal variants to display to 1000 varfish-org/varfish-server
1 participant
@holtgrewe