Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep scroll position after viewing variant details (#1273) #1464

Conversation

stolpeo
Copy link
Contributor

@stolpeo stolpeo commented Mar 21, 2024

No description provided.

Copy link

deps-report 🔍

Commit scanned: b769c72
ℹ️ Python version 3.10 is used by your project but the latest version is 3.12.

Vulnerable dependencies

2 dependencies have vulnerabilities 😱
Dependency Advisory Versions impacted
pyopenssl (transitive) CVE-2023-6129 affects PyOpenSSL versions starting from 22.0.0 due to a vulnerability in the POLY1305 MAC algorithm on PowerPC CPUs. This issue could lead to state corruption in applications, causing inaccurate outcomes or service disruptions. Attackers need specific conditions to exploit this flaw, including the ability to manipulate the algorithm's use and reliance on certain system registers by the application. >=22.0.0
sqlalchemy Sqlalchemy 2.0.0b1 avoids leaking cleartext passwords to the open for careless uses of str(engine.URL()) in logs and prints. sqlalchemy/sqlalchemy#8563 <2.0.0b1

Outdated dependencies

53 outdated dependencies found (including 17 outdated major versions)😢
Dependency Installed version Latest version
argon2-cffi (transitive) 21.3.0 23.1.0
billiard (transitive) 3.6.4.0 4.2.0
coverage (dev,transitive) 6.5.0 7.4.4
crispy-bootstrap4 (transitive) 2022.1 2024.1
django 3.2.24 5.0.3
faker (dev,transitive) 23.3.0 24.3.0
flake8 (dev) 6.1.0 7.0.0
lxml 4.9.4 5.1.0
mistune (transitive) 2.0.5 3.0.2
packaging (transitive) 23.2 24.0
protobuf 3.20.3 5.26.0
setuptools (transitive) 67.6.1 69.2.0
sphinx (transitive) 6.2.1 7.2.6
sphinx-rtd-theme (transitive) 1.2.2 2.0.0
sqlalchemy 1.4.51 2.0.28
unidecode (transitive) 0.4.21 1.3.8
xmlschema (transitive) 2.5.1 3.1.0
Dependency Installed version Latest version
aiobotocore (transitive) 2.12.0 2.12.1
asgiref (transitive) 3.7.2 3.8.0
black 24.2.0 24.3.0
botocore (transitive) 1.34.51 1.34.67
celery (transitive) 5.2.7 5.3.6
django-autocomplete-light (transitive) 3.9.4 3.11.0
django-crispy-forms (transitive) 2.0 2.1
django-db-file-storage (transitive) 0.5.5 0.5.6.1
django-environ (transitive) 0.10.0 0.11.2
django-iconify (transitive) 0.1.1 0.4
django-model-utils (transitive) 4.3.1 4.4.0
django-plugins-bihealth 0.4.0 0.5.2
django-postgres-copy 2.3.7 2.7.4
djangorestframework (transitive) 3.14.0 3.15.0
docutils (transitive) 0.18.1 0.20.1
drf-keyed-list-bihealth 0.1.1 0.2.1
drf-spectacular-sidecar (transitive) 2024.2.1 2024.3.4
elementpath (transitive) 4.3.0 4.4.0
fsspec (transitive) 2024.2.0 2024.3.1
ipython (dev,transitive) 8.22.1 8.22.2
markdown (transitive) 3.4.1 3.6
pydantic 2.6.3 2.6.4
pyflakes (dev,transitive) 3.1.0 3.2.0
pyopenssl (transitive) 24.0.0 24.1.0
python-dateutil 2.9.0 2.9.0.post0
redis 5.0.2 5.0.3
referencing (transitive) 0.33.0 0.34.0
requests-http-signature 0.2.0 0.7.1
s3fs 2024.2.0 2024.3.1
sentry-sdk 1.40.6 1.43.0
traitlets (dev,transitive) 5.14.1 5.14.2
trio (dev,transitive) 0.24.0 0.25.0
universal-pathlib 0.2.1 0.2.2
urllib3 (transitive) 2.0.7 2.2.1
versioneer (transitive) 0.28 0.29
wheel (transitive) 0.40.0 0.43.0

Logs

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 70%. Comparing base (e56ad93) to head (b769c72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1464    +/-   ##
======================================
- Coverage     70%     70%    -1%     
======================================
  Files        382     383     +1     
  Lines      24771   24944   +173     
  Branches    1602    1634    +32     
======================================
+ Hits       17473   17480     +7     
- Misses      7298    7464   +166     
Files Coverage Δ
variants/vueapp/src/stores/variantQuery.js 17% <50%> (+<1%) ⬆️
svs/vueapp/src/stores/svQuery.js 3% <0%> (ø)
svs/vueapp/src/components/SvFilterResultsTable.vue 11% <0%> (-1%) ⬇️
...iants/vueapp/src/components/FilterResultsTable.vue 2% <0%> (-1%) ⬇️

@stolpeo stolpeo merged commit d1f793c into main Mar 21, 2024
15 of 17 checks passed
@stolpeo stolpeo deleted the 1273-keep-table-position-after-viewing-variant-details-and-going-back-to-the-variant-table branch March 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep table position after viewing variant details and going back to the variant table
1 participant