Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Chanify as a Notification service #150

Merged
merged 5 commits into from
May 13, 2023

Conversation

0Charliecat
Copy link
Contributor

Adds Chanify (https://chanify.net) as a Notification service.
Please someone check it, thanks.

@variadico
Copy link
Owner

Almost there. Looks like you have some CI errors. Might want to run make lint test test-integration locally while fixing them.

@0Charliecat
Copy link
Contributor Author

thanks

@variadico
Copy link
Owner

variadico commented May 13, 2023

If you run make lint test test-integration locally, you'll have an instant feedback cycle. Otherwise, it seems like I have to approve the CI runs and that's gonna take a lot longer.

@0Charliecat
Copy link
Contributor Author

thanks, i didn't notice these errors when i ran it weird

  └──> make lint test test-integration
go vet ./...
# github.com/variadico/noti/service/nsuser
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:41:33: warning: 'NSUserNotificationCenter' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:118:12: note: 'NSUserNotificationCenter' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:41:91: warning: 'NSUserNotification' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:24:12: note: 'NSUserNotification' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:46:33: warning: 'NSUserNotificationCenter' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:118:12: note: 'NSUserNotificationCenter' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:46:94: warning: 'NSUserNotification' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:24:12: note: 'NSUserNotification' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:60:9: warning: 'NSUserNotificationCenter' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:118:12: note: 'NSUserNotificationCenter' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:60:66: warning: 'NSUserNotificationCenter' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:118:12: note: 'NSUserNotificationCenter' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:65:9: warning: 'NSUserNotification' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:24:12: note: 'NSUserNotification' has been explicitly marked deprecated here
In file included from service/nsuser/nsuser_darwin.go:9:
service/nsuser/nsuser_darwin.h:65:57: warning: 'NSUserNotification' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:24:12: note: 'NSUserNotification' has been explicitly marked deprecated here
./tools/golangci-lint-1.47.2-darwin-amd64 run --no-config --exclude-use-default=false --max-same-issues=0 \
        --timeout 30s \
        --disable errcheck \
        --disable stylecheck \
        --disable structcheck \
        --disable bodyclose \
        --enable unconvert \
        --enable dupl \
        --enable gocyclo \
        --enable gofmt \
        --enable goimports \
        --enable misspell \
        --enable lll \
        --enable unparam \
        --enable nakedret \
        --enable prealloc \
        --enable gocritic \
        --enable gochecknoinits \
        ./...
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

goroutine 1 [running]:
github.com/go-critic/go-critic/checkers.init.22()
        github.com/go-critic/go-critic@v0.6.3/checkers/embedded_rules.go:47 +0x4b4
make: *** [lint] Error 2

@variadico
Copy link
Owner

Oh, awesome. Thanks for posting that output. Something weird is going on. I'll take a look. I'm seeing the same panic on my Linux machine.

It was also helpful to post those NSUserNotificationCenter warnings. I don't have a Mac, so I haven't noticed that.

@variadico variadico merged commit 71cc04c into variadico:main May 13, 2023
3 checks passed
@variadico
Copy link
Owner

LGTM! Thanks! 🙏🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants