Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #4

Merged
merged 2 commits into from
Dec 11, 2015
Merged

Add Dockerfile #4

merged 2 commits into from
Dec 11, 2015

Conversation

DavidWittman
Copy link
Contributor

This adds a Dockerfile for variety-cli. I currently have the repository stored in Docker Hub at objectrocket/variety, which allows one to execute using Docker as follows:

$ docker run objectrocket/variety test/foo --host db.example.com --quiet --persistResults=true

@JamesCropcho
Copy link
Member

Thank you much for providing a Dockerfile, David. I'll admit I don't know much about this, but I'm happy to include it because it must be 1000x better than no Dockerfile.

I noticed that one of the CI checks—AppVeyor—is failing; not sure why. Tomáš, any ideas? David?

@JamesCropcho
Copy link
Member

Additionally, in a perfect world there would be a small piece of Docker documentation in the readme.

@DavidWittman
Copy link
Contributor Author

Thanks @JamesCropcho. Docker is really useful for running services/applications in a known state with little configuration. This way, you get a consistent build that works every time (hopefully) and you don't have to pollute any of the existing packages/configurations on your system. In effect, it reduces the steps to get Variety running on a system to a single command, provided Docker is available.

I'd be happy to add some documentation to the README... are you fine with me using the command for the Docker image in our objectrocket organization on Docker Hub as I did above? I wasn't sure if you preferred to maintain your own image or what.

@DavidWittman
Copy link
Contributor Author

Alright... I added some documentation for Docker to the README. Let me know if there's anything you'd like changed there.

@JamesCropcho
Copy link
Member

Awesome that we have documentation now, David.

are you fine with me using the command for the Docker image in our objectrocket organization on Docker Hub as I did above?

I don't have any opinion on it, so I'm fine leaving that as-is for now.

I'd say this is good to merge, save for that AppVeyor marks the branch as failed. I don't really know what AppVeyor is; Tomáš added it. Clicking through, I can't see why it's failing.

Tomáš (@tovdora), thoughts?

@todvora
Copy link
Contributor

todvora commented Dec 11, 2015

Hi all,
@DavidWittman: Thanks for the PR, it's a very good idea. Could you possibly also add some documentation (or maybe just a link back to the readme of this repo) on the Docker Hub?

I tested the Dockerfile on my machine and it runs flawlessly.

@JamesCropcho: The AppVeyor check failure has nothing to do with Docker or any of the changes in this PR. They simply stopped to support one of the tested versions of node:

node 1.5.1 x86 package not found

I am merging this and will fix AppVeyor right afterwards.

Thank you!

todvora added a commit that referenced this pull request Dec 11, 2015
@todvora todvora merged commit f1d8305 into variety:master Dec 11, 2015
@JamesCropcho
Copy link
Member

Great! I'm happy this is part of Variety now. And I'm sure that all fans of both Variety and Docker will agree with me :)

@DavidWittman
Copy link
Contributor Author

@todvora Good idea... I added some documentation on Docker Hub.

@DavidWittman DavidWittman deleted the dockerfile branch December 11, 2015 23:23
@todvora
Copy link
Contributor

todvora commented Dec 12, 2015

@DavidWittman perfect, thank you!

@JamesCropcho
Copy link
Member

@DavidWittman Thank you from me, too (ha)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants