-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile #4
Conversation
2da3c0b
to
734c49a
Compare
Thank you much for providing a Dockerfile, David. I'll admit I don't know much about this, but I'm happy to include it because it must be 1000x better than no Dockerfile. I noticed that one of the CI checks—AppVeyor—is failing; not sure why. Tomáš, any ideas? David? |
Additionally, in a perfect world there would be a small piece of Docker documentation in the readme. |
Thanks @JamesCropcho. Docker is really useful for running services/applications in a known state with little configuration. This way, you get a consistent build that works every time (hopefully) and you don't have to pollute any of the existing packages/configurations on your system. In effect, it reduces the steps to get Variety running on a system to a single command, provided Docker is available. I'd be happy to add some documentation to the README... are you fine with me using the command for the Docker image in our |
0e18c4b
to
1b287b0
Compare
Alright... I added some documentation for Docker to the README. Let me know if there's anything you'd like changed there. |
Awesome that we have documentation now, David.
I don't have any opinion on it, so I'm fine leaving that as-is for now. I'd say this is good to merge, save for that AppVeyor marks the branch as failed. I don't really know what AppVeyor is; Tomáš added it. Clicking through, I can't see why it's failing. Tomáš (@tovdora), thoughts? |
Hi all, I tested the Dockerfile on my machine and it runs flawlessly. @JamesCropcho: The AppVeyor check failure has nothing to do with Docker or any of the changes in this PR. They simply stopped to support one of the tested versions of node:
I am merging this and will fix AppVeyor right afterwards. Thank you! |
Great! I'm happy this is part of Variety now. And I'm sure that all fans of both Variety and Docker will agree with me :) |
@todvora Good idea... I added some documentation on Docker Hub. |
@DavidWittman perfect, thank you! |
@DavidWittman Thank you from me, too (ha)! |
This adds a Dockerfile for
variety-cli
. I currently have the repository stored in Docker Hub atobjectrocket/variety
, which allows one to execute using Docker as follows: