feat(swipe): support keyboard arrowLeft and arrowRight #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chouchouji is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chouchouji
changed the title
chouchouji
force-pushed
the
feat-image-preview
branch
from
a2fae8a
to
37b756a
Compare
|
那暂时按照目前的设计
…---Original---
From: ***@***.***>
Date: Fri, Jun 7, 2024 10:39 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [varletjs/varlet] WIP(swipe): support keyboard arrowLeft andarrowRight (PR #1659)
@haoziqaq 我看swiper这里没有做节流
image.png (view on web)
https://github.com/nolimits4web/swiper/blob/master/src/modules/keyboard/keyboard.mjs#L19
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ok，我晚上补充一下测试用例 |
chouchouji
force-pushed
the
feat-image-preview
branch
from
e3f9c53
to
aa48067
Compare
chouchouji
changed the title
haoziqaq
approved these changes
Jun 7, 2024
chouchouji
force-pushed
the
feat-image-preview
branch
from
aa48067
to
baaf426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.