Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/hexcode-support #29

Merged
merged 9 commits into from
Mar 2, 2020
Merged

feature/hexcode-support #29

merged 9 commits into from
Mar 2, 2020

Conversation

cdrani
Copy link
Contributor

@cdrani cdrani commented Feb 23, 2020 •
edited
Loading

  • clear root div on alert prompt
  • Add function to convert rgb to hexcode and include the hexcode string in card
  • Document functions
  • update layout styles of cards
    Screen Shot 2020-02-23 at 05 31 33

closes #21

@cdrani cdrani requested a review from varlevi February 23, 2020 12:33
@cdrani cdrani mentioned this pull request Feb 23, 2020
Open
@cdrani cdrani changed the base branch from master to beta February 24, 2020 22:42
@cdrani cdrani mentioned this pull request Feb 24, 2020
Closed
varlevi
varlevi reviewed Feb 26, 2020
View reviewed changes
Copy link
Owner

@varlevi varlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new comments and hex code algorithm looks really good, however, grid doesn't seem to be working quite right. There was also a small typo in the JS file.

js/script.js Outdated Show resolved Hide resolved
js/script.js Show resolved Hide resolved
css/styles.css
@@ -113,17 +112,39 @@ input:focus {
border-radius: 25% 15%;
}

.cards {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grid isn't looking so good on mobile...
Screen Shot 2020-02-25 at 7 59 43 PM
And things aren't quite right on larger screens either...
Screen Shot 2020-02-25 at 8 01 30 PM
I think that the margins and padding are messing up centering or something, but I haven't really had time to learn grid very well yet, so I don't really know. Maybe it would be better to just use flexbox?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with some changes that should fix these. However, I don't see this as too big of a concern if a modal feature will be implemented to display rgb and hex values. With the modal the card will only be the box with a filled in color and will fit perfectly into whichever layout scheme we go with.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, these changes won't make much difference in the long run, but for now this looks much better. Thanks!

js/script.js Show resolved Hide resolved
varlevi
varlevi approved these changes Mar 2, 2020
View reviewed changes
Copy link
Owner

@varlevi varlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

css/styles.css
@@ -113,17 +112,39 @@ input:focus {
border-radius: 25% 15%;
}

.cards {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, these changes won't make much difference in the long run, but for now this looks much better. Thanks!

@varlevi varlevi merged commit 83cd4f3 into varlevi:beta Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varlevi varlevi varlevi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hex value support.
2 participants
@cdrani @varlevi