Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen: ServiceTimeoutError #2

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Listen: ServiceTimeoutError #2

merged 1 commit into from
Jun 4, 2018

Conversation

vrothberg
Copy link
Contributor

Return a ServiceTimeoutError to allow API users to special case
timeouts.

Signed-off-by: Valentin Rothberg vrothberg@suse.com

Return a ServiceTimeoutError to allow API users to special case
timeouts.

Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 298

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 81.982%

Files with Coverage Reduction New Missed Lines %
varlink/idl/idl.go 68 96.88%
Totals Coverage Status
Change from base Build 297: 0.0%
Covered Lines: 546
Relevant Lines: 666

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 298

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 81.982%

Files with Coverage Reduction New Missed Lines %
varlink/idl/idl.go 68 96.88%
Totals Coverage Status
Change from base Build 297: 0.0%
Covered Lines: 546
Relevant Lines: 666

💛 - Coveralls

@haraldh haraldh merged commit e9fdc57 into varlink:master Jun 4, 2018
@vrothberg vrothberg deleted the service-timeout-handling branch June 4, 2018 16:33
@vrothberg
Copy link
Contributor Author

That was fast. Thanks a lot, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants