Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of libcurl usage (not releasing curl_handle at every request) #20

Closed
wants to merge 2 commits into from

Conversation

stephanepiel
Copy link

Hello,

Here is an optimization I've made on this libcurl vmod. I've used the ability offered by libcurl to reuse a curl_handle for multiple requests. It allows to keep active connections, DNS cache, etc... , thus improving performances.
Tested/used with varnish 4.0.2

Hope you will find this helpful.
Regards,

@fgsch
Copy link
Contributor

fgsch commented Nov 7, 2014

Hi. Thanks for the patch. I've reviewed it and have some questions:
Is there any reason for restricting the number of reuses? Have you had any experience indicating this is needed and/or it could vary from place to place (i.e. why is configurable)?
Also is there any functional reason to move vmod_curl_list inside vmod_curl_priv?
It's better to address different concerns in separate PR as it makes reviewing them easier.

@daghf
Copy link
Member

daghf commented Jan 25, 2016

No response since 2014. Closing this as timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants