Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

better error handling, fixes for parallel make, remove generated files from dist #21

Merged
merged 4 commits into from May 29, 2015

Conversation

nigoroll
Copy link

…ions which don't

# check for varnishapi.m4 in custom paths
dataroot=$(pkg-config --variable=datarootdir varnishapi)
dataroot=`pkg-config --variable=datarootdir varnishapi 2>/dev/null`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? $() isn't a bashism, it's part of POSIX sh.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 24/05/15 10:58, Tollef Fog Heen wrote:

In autogen.sh
#21 (comment):

check for varnishapi.m4 in custom paths -dataroot=$(pkg-config

--variable=datarootdir varnishapi) +dataroot=pkg-config --variable=datarootdir varnishapi 2>/dev/null

Really? $() isn't a bashism, it's part of POSIX sh.

thank you, seems like I got stuck way too far in the past.

+if [ -z "$dataroot" ] ; then + cat >&2 <<'EOF';

'' and ; are pointless here.

; yes.

http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_07_04

If any character in word is quoted, the delimiter shall be formed by

performing quote removal on word, and the here-document lines shall not be
expanded.

I'll update the patch, thanks for the review.

Nils
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVYaieAAoJEB3Nj1ejhovXFOcH/1sP/xpNYKQLAaJZEEYblrq9
Si0qOWi05m0zGmsn0sLOxiV6/pPOPYRSoKM9SJTvcBaI3bbBiigYSN9iw1SMK24E
eEsFhsYaaJbkSgxhHrsqpNlteMI12CTdgT8FHFbuh2gYZNFG/dOLbc1w93uHYD7P
vT0AqdisLO2/i146X1NgfugABhX2+eLGOUrxni61hhlOQwFnN7TUk/zUTgPveP5n
0ntHWUq8HdAe9xcxn9Jag8JNjpEOZYatN/hItdT+7NISvrLOmxuBUCSGwq0eAxE6
3gM2QSRYHyovoiLZMTkk18m/LrRsU3YA3DzTiRt0MfvO9u1b79XJKkGruWQcN6k=
=gfLz
-----END PGP SIGNATURE-----

@nigoroll nigoroll changed the title dont assume bash, emit the right error also for older pkg-config vers… emit the right error also for older pkg-config versions which don't May 24, 2015
@nigoroll
Copy link
Author

thanks again @tfheen

@nigoroll nigoroll changed the title emit the right error also for older pkg-config versions which don't better error handling, fixes for parallel make, remove generated files from dist May 28, 2015
daghf added a commit that referenced this pull request May 29, 2015
better error handling, fixes for parallel make, remove generated files from dist
@daghf daghf merged commit b5c54d1 into varnish:4.0 May 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants