Extra opts #143
Merged
Extra opts #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2020 17:12
This will match the default hitch configuration, making interaction between it and varnish easier.
daghf
approved these changes
Aug 13, 2020
|
Thank you Dag, I'll merge that on Monday after the bugwash.
…On Thu, Aug 13, 2020, 02:22 Dag Haavi Finstad ***@***.***> wrote:
***@***.**** approved this pull request.
No concerns from me - I think this should be fine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#143 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA42AKJ6PJV22JOEWLGLXXTSAOWF5ANCNFSM4P2PHG5Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR, but it could be contentious as it touches the default runtime options: listen to
PROXYprotocol on 8443 and activateH/2.This would only change setups that haven't modified the
Execstart=directove, which I believe are a minority. In return, it will offer super easyhitchintegration.