Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is $ABI vrt, exactly? #3356

Closed
nigoroll opened this issue Jun 19, 2020 · 2 comments
Closed

What is $ABI vrt, exactly? #3356

nigoroll opened this issue Jun 19, 2020 · 2 comments
Labels
a=duplicate Duplicate issue

Comments

@nigoroll
Copy link
Member

From a VMOD developer perspective, there should be clear and concise documentation about exactly what is allowed for $ABI vrt, namely which includes can be used. I guess the main question is really about cache.h, is it part of VRT or not? If it is was not, we would have changed the VRT version quite often in the past for no good reason (but we already know that and the decision was made as a safety measure). Also, there will be almost no VMOD which does not make use of the workspace API, so $ABI vrt would probably be quite useless for all practical purposes.

Right now, our documentation is either vague or contradictory. Some findings:

If it complies to the VRT and only needs to be rebuilt when breaking changes are introduced to the VRT API, use vrt.

Yes, but which files constitute that API?

good level of detail (namely, includes the actual file names), but out of sync with reality

Might suggest that cache.h was part of the ABI

@nigoroll nigoroll changed the title What is $VRT abi, exactly? What is $ABI vrt, exactly? Jun 19, 2020
@dridi
Copy link
Member

dridi commented Jun 19, 2020

#3355 dupe

@dridi dridi closed this as completed Jun 19, 2020
@dridi dridi added the a=duplicate Duplicate issue label Jun 19, 2020
@nigoroll
Copy link
Member Author

yeah, github had issues, I submitted twice after a 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a=duplicate Duplicate issue
Projects
None yet
Development

No branches or pull requests

2 participants