Ingo horizontal calendar #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selected date visible
| @@ -357,6 +363,65 @@ class Calendar extends Component { | |||
| return CalendarHeader; | |||
| } | |||
|
|
|||
| showLoader() { | |||
| if (this.props.LoaderComponent) { | |||
| return <LoaderComponent />; | |||
There was a problem hiding this comment.
this way, LoaderComponent will be undefined.
It should be return this.props.LoaderComponent()
thoughts?
There was a problem hiding this comment.
yeah, seems like i made a mistake. will have to check
There was a problem hiding this comment.
will you plz correct it whenever you get time? plz...
There was a problem hiding this comment.
Please create a PR. I'll merge it
There was a problem hiding this comment.
Fork the repo, make changes to your forked repo and then you can create PR
|
while pushing the changes, its giving the error =>
remote: Permission to varunon9/react-native-toggle-calendar.git denied to
Abhijeetjaiswalit.
…On Fri, Nov 22, 2019 at 3:35 PM Varun kumar ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/calendar/index.js
<#1 (comment)>
:
> @@ -357,6 +363,65 @@ class Calendar extends Component {
return CalendarHeader;
}
+ showLoader() {
+ if (this.props.LoaderComponent) {
+ return <LoaderComponent />;
Please create a PR. I'll merge it
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AG6FLLWIGRAP5HOCTZHHLUDQU6VE7A5CNFSM4G7SIN3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMUNLNY#discussion_r349518746>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6FLLRSHLJIDA7AJWOZ42TQU6VE7ANCNFSM4G7SIN3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.