Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captions to tables #187

Merged
merged 3 commits into from Feb 15, 2017
Merged

Add captions to tables #187

merged 3 commits into from Feb 15, 2017

Conversation

ramhoj
Copy link
Contributor

@ramhoj ramhoj commented Mar 6, 2016

semantic and nice when testing

@jensljungblad
Copy link
Collaborator

Does it still work in tests if we would add a .sr-only class to the caption? That is, only include it for screen readers. Visually we already have the information about what table we're listing (e.g. articles) in the breadcrumb.

@ramhoj
Copy link
Contributor Author

ramhoj commented Feb 15, 2017

Pretty sure the caption can have any css class attached to it without casing any problems for the Rspec matcher.

@jensljungblad jensljungblad merged commit 81b91b6 into master Feb 15, 2017
@jensljungblad jensljungblad deleted the table-captions branch February 15, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants