Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpec 3 #106

Merged
merged 1 commit into from Feb 11, 2014
Merged

RSpec 3 #106

merged 1 commit into from Feb 11, 2014

Conversation

chrislegault
Copy link
Contributor

  • Updated gemspec to use RSpec 3
  • Updated tests to match new expect syntax

Fixes #82

@chrislegault
- Updated gemspec to use RSpec 3
0e85e0c 
- Updated tests to match new expect syntax
@thomasklemm
Copy link
Collaborator

This PR looks good to me, thanks very much @AstralDragon. I don't think that it fixes #82 though, as it looks to me that @JakubRacek mentions that pundit's included matchers need some updates.

thomasklemm added a commit that referenced this pull request Feb 11, 2014
@thomasklemm
Merge pull request #106 from astraldragon/rspec3
e7541c4 
Update specs to use the expect syntax and RSpec 3.0 beta
@thomasklemm thomasklemm merged commit e7541c4 into varvet:master Feb 11, 2014
@thomasklemm thomasklemm mentioned this pull request Feb 11, 2014
Closed
@chrislegault
Copy link
Contributor Author

Oh sorry. I misread it, I can look into that as well and make appropriate changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please update to work with rspec 3.0(beta)
2 participants
@chrislegault @thomasklemm