Replies: 1 comment
-
Can you make a PR for this? This was implemented earlier but there was an problem with that implementation. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Greetings to all. I have been working in my spare time with WBOT. and is analyzing how the chromium download issue works.
specifically the detectRev.js file.
Commented on lines 21-25. I decided to reactivate it and see what was the problem or the reason why it was deactivated. At first it worked very well for me. but as the days went by I started to have problems. I explain a little to put the discovered in context.
https://omahaproxy.appspot.com/ is used to find the latest Chromium distributions that are compatible with PuppeteerJS. for that reason they are filtered based on the "canary" property However, the problem occurs when these versions are not exactly downloadable distributions.
https://omahaproxy.appspot.com/all.json?os=win
In my case is Rev. 868734
https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/868734/chrome-win.zip
Why is this failing?
Basically the developers of Cromium create a new version, this version is published and available for download, however when finding serious bugs, the version is removed from the download part. This generates an error in the
downloadAndStartThings()
function. Specifically in the part of src/index.jsawait browserFetcher.download (revNumber)
Because although the revision number exists, it is not available for download.
Solution:
After reviewing the above. I found a way to be able to download the recent, stable and permanent versions of cromium. Basically, it is to look directly at the download source and from there take the number corresponding to the revision.
https://www.googleapis.com/storage/v1/b/chromium-browser-snapshots/o?&delimiter=/&prefix=[OS_PLATFORM]/&fields=prefixes
the mechanism is almost identical, you just have to use this URL and make a couple of adjustments in the inside of the function so that it correctly searches for what is required. It is still too early to win, more tests are required, more community support to check on different OS and see the impact on performance but it seems like a good solution.
I also understand that fixing the version is due to problems with PuppeteerJS. to safeguard compatibility and stuff. But I always recommend keeping applications up to date and this is a way to automatically update the kernel
Beta Was this translation helpful? Give feedback.
All reactions