Fix number inputs (patch)

vasco3 · Sep 22, 2018 · 0f54011 · 0f54011
1 parent b760bf5
commit 0f54011
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 21 deletions.
diff --git a/src/calculator/Calculator.js b/src/calculator/Calculator.js
@@ -152,8 +152,7 @@ class Calculator extends React.Component {
                       onBlur={handleBlur}
                       onChange={handleChange}
                       outlined
-                      type="number"
-                      value={values.calories}
+                      defaultValue={values.calories}
                     />
                     {errors.calories && (
                       <TextFieldHelperText validationMsg persistent>
@@ -169,8 +168,7 @@ class Calculator extends React.Component {
                       onBlur={handleBlur}
                       onChange={handleChange}
                       outlined
-                      type="number"
-                      value={values.caloriesExtraForWorkoutDay}
+                      defaultValue={values.caloriesExtraForWorkoutDay}
                     />
                     {errors.caloriesExtraForWorkoutDay && (
                       <TextFieldHelperText validationMsg persistent>
@@ -181,34 +179,32 @@ class Calculator extends React.Component {
                   <GridCell span="4">
                     <TextField
                       className="mb-4 mr-4"
-                      label="Fat % from calories"
-                      name="fatCaloriesRatio"
+                      label="Body weight (lbs)"
+                      name="bodyWeight"
                       onBlur={handleBlur}
                       onChange={handleChange}
                       outlined
-                      type="number"
-                      value={values.fatCaloriesRatio}
+                      defaultValue={values.bodyWeight}
                     />
-                    {errors.fatCaloriesRatio && (
+                    {errors.bodyWeight && (
                       <TextFieldHelperText validationMsg persistent>
-                        {errors.fatCaloriesRatio}
+                        {errors.bodyWeight}
                       </TextFieldHelperText>
                     )}
                   </GridCell>
                   <GridCell span="4">
                     <TextField
                       className="mb-4 mr-4"
-                      label="Body weight (lbs)"
-                      name="bodyWeight"
+                      label="Fat % from calories"
+                      name="fatCaloriesRatio"
                       onBlur={handleBlur}
                       onChange={handleChange}
                       outlined
-                      type="number"
-                      value={values.bodyWeight}
+                      defaultValue={values.fatCaloriesRatio}
                     />
-                    {errors.bodyWeight && (
+                    {errors.fatCaloriesRatio && (
                       <TextFieldHelperText validationMsg persistent>
-                        {errors.bodyWeight}
+                        {errors.fatCaloriesRatio}
                       </TextFieldHelperText>
                     )}
                   </GridCell>
@@ -220,8 +216,7 @@ class Calculator extends React.Component {
                       onBlur={handleBlur}
                       onChange={handleChange}
                       outlined
-                      type="number"
-                      value={values.proteinGramsPerBodyWeightLb}
+                      defaultValue={values.proteinGramsPerBodyWeightLb}
                     />
                     {errors.proteinGramsPerBodyWeightLb && (
                       <TextFieldHelperText validationMsg persistent>

diff --git a/src/recipes/RecipeForm.js b/src/recipes/RecipeForm.js
@@ -48,20 +48,19 @@ const RecipeForm = ({ recipe = {}, onCancel, onSave }) => {
           <Form>
             <div className="flex flex-wrap p-4">
               {RECIPE_ATTRIBUTES.map(function mapRecipeForm(
-                { name, label, defaultValue },
+                { name, label },
                 index,
               ) {
                 return (
                   <TextField
                     className="mb-4 mr-4"
                     key={index}
                     name={name}
-                    value={values[name]}
+                    defaultValue={values[name]}
                     onBlur={handleBlur}
                     outlined
                     label={label}
                     onChange={handleChange}
-                    type={typeof defaultValue === 'string' ? 'text' : 'number'}
                   />
                 );
               })}