Add small theme improvements (#303)

vase4kin · Mar 21, 2020 · 0aebf18 · 0aebf18
1 parent 2d3a592
commit 0aebf18
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 13 deletions.
diff --git a/app/src/main/res/layout/activity_artifact_list.xml b/app/src/main/res/layout/activity_artifact_list.xml
@@ -42,7 +42,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
             tools:listitem="@layout/item_artifact_list" />

diff --git a/app/src/main/res/layout/activity_build_list.xml b/app/src/main/res/layout/activity_build_list.xml
@@ -42,7 +42,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             tools:listitem="@layout/item_build_list" />

diff --git a/app/src/main/res/layout/activity_navigation_list.xml b/app/src/main/res/layout/activity_navigation_list.xml
@@ -43,7 +43,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             tools:listitem="@layout/item_navigation_list" />

diff --git a/app/src/main/res/layout/fragment_build_list.xml b/app/src/main/res/layout/fragment_build_list.xml
@@ -30,7 +30,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             tools:listitem="@layout/item_build_list" />

diff --git a/app/src/main/res/layout/fragment_favorites.xml b/app/src/main/res/layout/fragment_favorites.xml
@@ -31,7 +31,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             tools:listitem="@layout/item_navigation_list" />

diff --git a/app/src/main/res/layout/fragment_list.xml b/app/src/main/res/layout/fragment_list.xml
@@ -30,7 +30,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
             tools:listitem="@layout/item_agent_list" />

diff --git a/app/src/main/res/layout/fragment_overview_list.xml b/app/src/main/res/layout/fragment_overview_list.xml
@@ -29,7 +29,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
             android:clipToPadding="false"

diff --git a/app/src/main/res/layout/fragment_snapshot_dependencies.xml b/app/src/main/res/layout/fragment_snapshot_dependencies.xml
@@ -30,7 +30,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="wrap_content" />
 

diff --git a/features/manage-accounts/src/main/res/layout/activity_manage_accounts.xml b/features/manage-accounts/src/main/res/layout/activity_manage_accounts.xml
@@ -45,7 +45,6 @@
 
         <androidx.recyclerview.widget.RecyclerView
             android:id="@+id/my_recycler_view"
-            style="@style/RecyclerView"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
             app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"

diff --git a/libraries/theme/src/main/res/values-night/themes.xml b/libraries/theme/src/main/res/values-night/themes.xml
@@ -29,7 +29,7 @@
         <item name="colorOnBackground">@color/white_50</item>
         <item name="colorOnSurface">@color/white_50</item>
         <item name="colorOnError">@color/black_900</item>
-        <item name="colorOnHeaderBackground">?android:attr/colorBackground</item>
+        <item name="colorSecondaryBackground">?android:attr/colorBackground</item>
         <item name="android:windowLightStatusBar" tools:targetApi="m">false</item>
         <item name="android:windowLightNavigationBar" tools:ignore="NewApi">false</item>
     </style>

diff --git a/libraries/theme/src/main/res/values/attrs.xml b/libraries/theme/src/main/res/values/attrs.xml
@@ -15,5 +15,5 @@
   -->
 
 <resources>
-    <attr name="colorOnHeaderBackground" format="color" />
+    <attr name="colorSecondaryBackground" format="color" />
 </resources>
diff --git a/libraries/theme/src/main/res/values/styles.xml b/libraries/theme/src/main/res/values/styles.xml
@@ -94,7 +94,7 @@
         <item name="android:foreground">?attr/selectableItemBackground</item>
         <item name="android:textColor">@color/material_on_background_emphasis_medium</item>
         <item name="android:textStyle">bold</item>
-        <item name="android:background">?attr/colorOnHeaderBackground</item>
+        <item name="android:background">?attr/colorSecondaryBackground</item>
         <item name="android:clickable">true</item>
     </style>
 

diff --git a/libraries/theme/src/main/res/values/themes.xml b/libraries/theme/src/main/res/values/themes.xml
@@ -44,7 +44,7 @@
         <item name="colorOnSurface">@color/black_900</item>
         <item name="colorOnError">@color/white_50</item>
         <!--Custom colors-->
-        <item name="colorOnHeaderBackground">@color/grey_100</item>
+        <item name="colorSecondaryBackground">@color/grey_100</item>
         <!--Material type attributes-->
         <item name="textAppearanceHeadline1">@style/TextAppearance.MyTheme.Headline1</item>
         <item name="textAppearanceHeadline2">@style/TextAppearance.MyTheme.Headline2</item>
@@ -82,6 +82,7 @@
         <item name="tabStyle">@style/TabLayout</item>
         <item name="textInputStyle">@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox
         </item>
+        <item name="recyclerViewStyle">@style/RecyclerView</item>
     </style>
 
     <style name="Base.Theme" parent="Theme.MaterialComponents.DayNight.NoActionBar">