Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

Add small theme improvements #303

Merged
merged 1 commit into from
Mar 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/res/layout/activity_artifact_list.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:listitem="@layout/item_artifact_list" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/activity_build_list.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="wrap_content"
tools:listitem="@layout/item_build_list" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/activity_navigation_list.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="wrap_content"
tools:listitem="@layout/item_navigation_list" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/fragment_build_list.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="wrap_content"
tools:listitem="@layout/item_build_list" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/fragment_favorites.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="wrap_content"
tools:listitem="@layout/item_navigation_list" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/fragment_list.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:listitem="@layout/item_agent_list" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/fragment_overview_list.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/fragment_snapshot_dependencies.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="wrap_content" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/my_recycler_view"
style="@style/RecyclerView"
android:layout_width="match_parent"
android:layout_height="match_parent"
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
Expand Down
2 changes: 1 addition & 1 deletion libraries/theme/src/main/res/values-night/themes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<item name="colorOnBackground">@color/white_50</item>
<item name="colorOnSurface">@color/white_50</item>
<item name="colorOnError">@color/black_900</item>
<item name="colorOnHeaderBackground">?android:attr/colorBackground</item>
<item name="colorSecondaryBackground">?android:attr/colorBackground</item>
<item name="android:windowLightStatusBar" tools:targetApi="m">false</item>
<item name="android:windowLightNavigationBar" tools:ignore="NewApi">false</item>
</style>
Expand Down
2 changes: 1 addition & 1 deletion libraries/theme/src/main/res/values/attrs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
-->

<resources>
<attr name="colorOnHeaderBackground" format="color" />
<attr name="colorSecondaryBackground" format="color" />
</resources>
2 changes: 1 addition & 1 deletion libraries/theme/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<item name="android:foreground">?attr/selectableItemBackground</item>
<item name="android:textColor">@color/material_on_background_emphasis_medium</item>
<item name="android:textStyle">bold</item>
<item name="android:background">?attr/colorOnHeaderBackground</item>
<item name="android:background">?attr/colorSecondaryBackground</item>
<item name="android:clickable">true</item>
</style>

Expand Down
3 changes: 2 additions & 1 deletion libraries/theme/src/main/res/values/themes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<item name="colorOnSurface">@color/black_900</item>
<item name="colorOnError">@color/white_50</item>
<!--Custom colors-->
<item name="colorOnHeaderBackground">@color/grey_100</item>
<item name="colorSecondaryBackground">@color/grey_100</item>
<!--Material type attributes-->
<item name="textAppearanceHeadline1">@style/TextAppearance.MyTheme.Headline1</item>
<item name="textAppearanceHeadline2">@style/TextAppearance.MyTheme.Headline2</item>
Expand Down Expand Up @@ -82,6 +82,7 @@
<item name="tabStyle">@style/TabLayout</item>
<item name="textInputStyle">@style/Widget.MaterialComponents.TextInputLayout.OutlinedBox
</item>
<item name="recyclerViewStyle">@style/RecyclerView</item>
</style>

<style name="Base.Theme" parent="Theme.MaterialComponents.DayNight.NoActionBar">
Expand Down