-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tar index doesn't work on large files #55
Comments
That's weird, because during the configuration step of the build, the large file support should be figured out correctly. But maybe it is some other issue than large file support. @hisnameishb Would you please let us know about your architecture and how @hisnameishb I have some additional questions, because without more details it will be hard for us to reproduce this issue to finally be able to fix it:
@vasi I don't yet have fully understood how the |
@hisnameishb If you sent this via email, GitHub apparently does not include the attachment. Would you please go to the GitHub issues page and post the contents of |
@hisnameishb In the meantime, if have written a small patch that may shed some light on the issue. Please apply this patch, recompile and try listing again:
Possibly, there will be more output as to why seeking in this file does not work. |
|
I patched it right now and create the tpxz again, takes some time... |
@hisnameishb You did not need to re-create the tpxz file again, the patch only concerns listing. |
Yes, I know but I deleted the tpxz, so I had to recreate it. I unpacked the pixz1.05-source into an new folder and then: |
I approve of adding better error reporting. 👍 Otherwise, I'm not sure what the problem could be! |
@hisnameishb Thanks for all the reports. @vasi With the patch I already excluded the possibility that it is |
Yeah, and it looks like his build does has _FILE_OFFSET_BITS=64 . But then it's weird that listing is only failing for @hisnameishb for large files! Maybe there's an improperly sized variable somewhere, but then it should be failing for everyone.... @hisnameishb: Could you try listing several different pixz-compressed tarballs? Maybe include at least one that's smaller than 1 GiB, and at least two that are bigger than 2 GiB, so we can make sure that file size is not the problem. |
Ok, I test it with different sizes. |
tar ~100MB -> tpxz ????MB : listing works |
Seems something wrong with large file support here. |
I'm the culprit that originally asked for big file support and still had The problem is in common.c in the decode_index() function when calling Back up in config.h, we do have _FILE_OFFSET_BITS defined as 64, but... I just included config.h at the top of common.c and rebuilt and now the On 11/4/2015 7:54 PM, Christopher Meng wrote:
|
Thanks for all the reports. I will include this fix later today and release a new version. |
I opted to include @hisnameishb Would you please verify that the listing works now on your machine as well? Testing this in travis would be kinda awkward, maybe not even possible at all, because I doubt they'll let you create more than 4GB per test run. |
pixz 1.05:
8,7GB tar after indexing/packing it with pixz I do
pixz -l bigtar.tpxz
Can't list non-seekable input
With small files it works.
The text was updated successfully, but these errors were encountered: