day 144: bounds check with a panic

vaskoz · Jan 17, 2019 · 0ceecd5 · 0ceecd5
1 parent aa56c17
commit 0ceecd5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/day144/problem.go b/day144/problem.go
@@ -5,6 +5,9 @@ package day144
 // If no number if found, then -1 is returned.
 // Runs in O(N) time.
 func ClosestLargerNumberIndexBrute(nums []int, targetIndex int) int {
+	if targetIndex < 0 || targetIndex >= len(nums) {
+		panic("index out of bounds")
+	}
 	val := nums[targetIndex]
 	left, right := targetIndex-1, targetIndex+1
 	for left >= 0 || right < len(nums) {

diff --git a/day144/problem_test.go b/day144/problem_test.go
@@ -21,6 +21,16 @@ func TestClosestLargerNumberIndexBrute(t *testing.T) {
 	}
 }
 
+func TestClosestLargerNumberIndexBruteBoundsCheck(t *testing.T) {
+	t.Parallel()
+	defer func() {
+		if err := recover(); err == nil {
+			t.Errorf("It should panic with an index out of bounds")
+		}
+	}()
+	ClosestLargerNumberIndexBrute([]int{1, 2}, 3)
+}
+
 func BenchmarkClosestLargerNumberIndexBrute(b *testing.B) {
 	for i := 0; i < b.N; i++ {
 		for _, tc := range testcases {