don't expose the error via an exported variable. Instead call a function

vaskoz · Sep 3, 2018 · 786ff58 · 786ff58
1 parent a3bbceb
commit 786ff58
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/closestmanager/closestmanager.go b/closestmanager/closestmanager.go
@@ -13,7 +13,8 @@ type Employee struct {
 
 var errNoCommonManager = fmt.Errorf("No common manager found")
 
-func getNoCommonManagerError() error {
+// NoCommonManagerError returns the errNoCommonManager error owned by the package.
+func NoCommonManagerError() error {
 	return errNoCommonManager
 }
 
@@ -30,5 +31,5 @@ func FindClosestManager(empMgrMap map[Employee]*Employee, e1, e2 Employee) (Empl
 		}
 		e2 = *mgr
 	}
-	return Employee{}, getNoCommonManagerError()
+	return Employee{}, NoCommonManagerError()
 }
diff --git a/closestmanager/closestmanager_test.go b/closestmanager/closestmanager_test.go
@@ -37,7 +37,7 @@ var testcases = []struct {
 	{employees["vpoe"], employees["vpop"], employees["ceo"], nil},
 	{employees["opsDirector"], employees["swMgr"], employees["vpoe"], nil},
 	{employees["otherMgr"], employees["swMgr"], employees["softDirector"], nil},
-	{employees["vpoe"], employees["ceo"], &Employee{}, getNoCommonManagerError()},
+	{employees["vpoe"], employees["ceo"], &Employee{}, NoCommonManagerError()},
 }
 
 func TestFindClosestManagerMap(t *testing.T) {