Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.5 + 3.6: Use correct cache dir for caching tiles #1049

Merged
merged 1 commit into from Dec 3, 2021

Conversation

uckelman
Copy link
Contributor

@uckelman uckelman commented Dec 3, 2021

Call Info.getCacheDir() to get the cache dir if Info.getCacheDir() exists to be called. (I.e., we are running in Vassal 3.6+.) If not, call Info.getConfDir(), for Vassal 3.5.

This patch targets both Vassal 3.5 and 3.6. Patch #1048 should be applied when you're ready to do a release based on 3.6.

exists to be called. (I.e., we are running in Vassal 3.6+.) If not, call
Info.getConfDir(), for Vassal 3.5.
@derimmer
Copy link
Contributor

derimmer commented Dec 3, 2021

@uckelman - checking to be sure I understand this properly.

Release of VASL6.6.4 is planned for next spring and it will be based on 3.6 (or whatever is the latest by then). So for that release I need to apply Patch #1048?

Do we need to issue a new version of the current VASL mod 6.6.3 using this Patch #1049? Can we just wait until the spring or will users experience errors when using 6.6.3 with either 3.5.8/3.6?

@uckelman
Copy link
Contributor Author

uckelman commented Dec 3, 2021

Yes, #1048 is for the a VASL release where you want the minimum Vassal version to be 3.6. I presume that will be the planned spring one.

I would appreciate it if you could do a release with this patch (#1049) as soon as possible.
VASL 6.6.3 isn't able to load board tiles in Vassal 3.6, so is completely unusable, and we'll have endless complaints if there's no usable VASL release until spring.

@derimmer
Copy link
Contributor

derimmer commented Dec 3, 2021

Will do.

@derimmer derimmer merged commit 192a477 into vasl-developers:develop Dec 3, 2021
@uckelman uckelman deleted the tile_dir_fix_3.5 branch December 4, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants