Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop fixes #114

Merged
merged 35 commits into from
Nov 6, 2023
Merged

Workshop fixes #114

merged 35 commits into from
Nov 6, 2023

Conversation

sudarshanv01
Copy link
Collaborator

No description provided.

sudarshanv01 and others added 29 commits August 1, 2023 14:25
@sudarshanv01
Copy link
Collaborator Author

isort on the __init__.py is failing - I worry that placing imports by isort will lead to circular imports the way it is currently designed. Note that MLFFErrorAnalysis is exposed in this PR as from py4vasp import MLFFErrorAnalysis

@sudarshanv01 sudarshanv01 merged commit 9eddc36 into master Nov 6, 2023
21 checks passed
@sudarshanv01 sudarshanv01 deleted the workshop-fixes branch November 6, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants