Update pyproject.toml - add mdtraj dependency #141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I recently installed py4vasp and it was missing 'mdtraj' package:
`File ~/.local/lib/python3.10/site-packages/py4vasp/_data/structure.py:8
5 from dataclasses import dataclass
7 import ase.io
----> 8 import mdtraj
9 import numpy as np
10 from IPython.lib.pretty import pretty
ModuleNotFoundError: No module named 'mdtraj'`
It should be listed in py4vasp's dependencies, right? Version 1.9.9 worked fine for me, so I put '>=1.9.9' version specifier into the PR. Feel free to edit the PR if you think an older version would be better.
Cheers,
Jan