Cleanup package structure #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __init__.py file is renamed to control.py in the main py4vasp directory and all other files are moved to a _control subfolder. Then only the public parts of the class are imported.
The __init__.py file is renamed to data.py in the main directory of py4vasp and all the other files are moved to a _data directory. Then the public ones are imported in __init__.py.
Rename __init__.py to raw.py and move it to the main directory of py4vasp. Then move all files to a _raw directory and import the public interfaces. Remove deprecated code.
Add import order to CI and makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.