Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined Refresher includes deck add/delete exceptions in error counts but does not highlight as warnings in the log. #13366

Open
riverwanderer opened this issue Jun 6, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@riverwanderer
Copy link
Collaborator

The Vassal 3.7 enhanced Predefined Setup Refresher includes deck add/delete exceptions in error counts but does not highlight these as warnings in the log. This could cause some confusion such as highlighted in this forum post.

The refresher counts Delete and Add deck requests as exceptions if there are no decks to delete or add in the game file.
However, the log simply reports zero in these categories without indicating that the refresh has counted the event as a "warning".

For example:
image

Either zero conditions should not be accumulated in the warning count or should be highlighted as warning in the log. Or, with more work on the PDS Referesh / Game Refresher interface, the summary of warning counts could be more detailed.

@riverwanderer riverwanderer added the enhancement New feature or request label Jun 6, 2024
@riverwanderer riverwanderer added this to the 3.7.13 milestone Jun 6, 2024
@uckelman uckelman modified the milestones: 3.7.13, 3.7.14 Jul 25, 2024
@uckelman uckelman modified the milestones: 3.7.14, 3.7.15 Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants