3.4.6 - 13505 - Deck band select fix #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to have made this fix against Master not Release 3-4-6? |
|
Oh thanks for pointing that out -- I actually made it against Release 3.4.6 but hadn't marked that in the PR. |
|
Where you able to test this on a Mac Brian? Otherwise, we will need to get a snapshot build for the Mac guys to try out. |
|
I didn't end up borrowing my wife's Mac, because I was actually seeing the band-select problem happen in Windows using that guy's module (no idea why his does it a lot worse than PoG, but anyway). So I'm certainly not against a snapshot build though I'm not sure it's actually necessary -- since problem was happening for me and now it's not. |
uckelman
requested changes
Oct 11, 2020
vassal-app/src/main/java/VASSAL/build/module/map/KeyBufferer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a thread on the forums (http://www.vassalengine.org/forum/viewtopic.php?f=3&t=11438) where they are complaining about it doing a band-select when you drag things off a deck.
For some reason this problem seems "worse" on Macs than on PC, but I am able to see at least some of the problem on PC.
In any event, I this this PR should fix the problem. Doesn't allow band-selects to start on top of a deck.