Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masthead and search fixes #55

Merged
merged 1 commit into from Aug 15, 2022
Merged

Masthead and search fixes #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/sections/universal_sections/hamburgerNavigation.inc
View file
Open in desktop
Expand Up @@ -91,7 +91,7 @@ $template = <<<TMP
</ul>
</div>

<form action="/search/" class="g-Search__form mt-4" method="get">
<form action="https://www.vassar.edu/search/" class="g-Search__form mt-4" method="get">
<div class="input-group mb-3">
<input class="g-Search__field form-control" id="g-Search__field" name="q" placeholder="Search" type="search" aria-label="Search" aria-describedby="button-addon2">
<button class="icon icon-search g-Search__submit" name="submit" tabindex="0" type="submit" id="button-addon2">
Expand Down
18 changes: 18 additions & 0 deletions core/sections/universal_sections/siteHeader_video_adv.inc
View file
Open in desktop
@@ -1,6 +1,24 @@

<?php

if( isset( $_GET["masthead"] ) ) {
$masthead_style = $_GET["masthead"];

if( $masthead_style == 'new-title') {

}
else if( $masthead_style == 'tagline') {

}
else if( $masthead_style == 'alumnaei') {

}
}
else {

}


/* Sometimes the animation isn't visible. What seems to be happening is that the script thinks the Vimeo video has loaded before it actually appears in the embed, so it starts playing the animation.

I'm wondering about embedding the video as an HTML5 video element, and using https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/loadeddata_event - maybe that's more accurate? Or is there a way to do this via the Vimeo API?
Expand Down
3 changes: 3 additions & 0 deletions core/template-parts/header.inc
View file
Open in desktop
Expand Up @@ -76,6 +76,7 @@ $page_url = "https://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]";
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">

<!--
<meta property="og:title" content="$page_title">
<meta property="twitter:title" content="$page_title">
<meta name="twitter:site" content="@vassar">
Expand All @@ -87,6 +88,8 @@ $page_url = "https://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]";
<meta name="twitter:card" content="summary_large_image" />
<meta property="og:image" content="https://{$_SERVER['HTTP_HOST']}$feature_image">
<meta property="twitter:image" content="https://{$_SERVER['HTTP_HOST']}$feature_image">
-->


$comment

Expand Down