code cleanup following review

vatesfr · Jan 12, 2022 · c7a2901 · c7a2901
1 parent 6b706cc
commit c7a2901
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/@xen-orchestra/backups/_cleanVm.js b/@xen-orchestra/backups/_cleanVm.js
@@ -153,13 +153,13 @@ async function checkAliases(aliasPaths, targetDataRepository, { handler, onLog =
 
     try {
       const { dispose } = await openVhd(handler, target)
-      dispose()
-    } catch (e) {
-      onLog(`target ${target} of alias ${path} is missing or broken`)
+      await dispose()
+    } catch (error) {
+      onLog(`target ${target} of alias ${path} is missing or broken`, { error })
       if (remove) {
         try {
           await VhdAbstract.unlink(handler, path)
-        } catch(e){}
+        } catch (e) {}
       }
       continue
     }

diff --git a/packages/vhd-lib/Vhd/VhdDirectory.js b/packages/vhd-lib/Vhd/VhdDirectory.js
@@ -178,9 +178,7 @@ exports.VhdDirectory = class VhdDirectory extends VhdAbstract {
       bufHeader = (await this._readChunk('header')).buffer
       bufFooter = (await this._readChunk('footer')).buffer
     } catch (error) {
-      // to keep as much as possible of the vhdFile way of handlong broken vhd
-      // let's emit an assertion error (the vhd is broken, you should try to delete it)
-      // instead of a file not found error (the vhd is missing)
+      // emit an AssertionError if the VHD is broken to stay as close as possible to the VhdFile API
       if (error.code === 'ENOENT') {
         assert(false, 'Header And Footer should exists')
       } else {