fix(xo-server-audit/getRecords): limit number of records returned (#6113

)

CHANGELOG.unreleased.md

@@ -11,6 +11,8 @@
 
 > Users must be able to say: “I had this issue, happy to know it's fixed”
 
+- [Plugin/Audit] Fix long data loading when displaying logs (PR [#6113](https://github.com/vatesfr/xen-orchestra/pull/6113))
+
 ### Packages to release
 
 > Packages will be released in the order they are here, therefore, they should
@@ -27,3 +29,5 @@
 > - major: if the change breaks compatibility
 >
 > In case of conflict, the highest (lowest in previous list) `$version` wins.
+
+- xo-server-audit patch

packages/xo-server-audit/src/index.js

@@ -197,6 +197,10 @@ class AuditXoPlugin {
     getRecords.permission = 'admin'
     getRecords.params = {
       id: { type: 'string', optional: true },
+
+      // null is used to bypass the default limit
+      maxRecords: { type: ['number', 'null'], optional: true },
+
       ndjson: { type: 'boolean', optional: true },
     }
 
@@ -290,12 +294,12 @@ class AuditXoPlugin {
     }
   }
 
-  async _getRecords({ id, ndjson = false }) {
+  async _getRecords({ id, maxRecords = 10e3, ndjson = false }) {
     if (ndjson) {
       return this._xo
         .registerHttpRequest((req, res) => {
           res.set('Content-Type', 'application/json')
-          return fromCallback(pipeline, this._getRecordsStream(id), res)
+          return fromCallback(pipeline, this._getRecordsStream(id, maxRecords === null ? undefined : maxRecords), res)
         })
         .then($getFrom => ({
           $getFrom,
@@ -427,8 +431,12 @@ class AuditXoPlugin {
   }
 }
 
-AuditXoPlugin.prototype._getRecordsStream = asyncIteratorToStream(async function* (id) {
+AuditXoPlugin.prototype._getRecordsStream = asyncIteratorToStream(async function* (id, maxRecords = Infinity) {
   for await (const record of this._auditCore.getFrom(id)) {
+    if (--maxRecords < 0) {
+      break
+    }
+
     yield JSON.stringify(record)
     yield '\n'
   }