feat(backups): store if disks of incremental backups are differencing…

… in metadata
vatesfr · Dec 19, 2023 · e13d55b · e13d55b
1 parent 141c141
commit e13d55b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/@xen-orchestra/backups/_cleanVm.mjs b/@xen-orchestra/backups/_cleanVm.mjs
@@ -556,7 +556,14 @@ export async function cleanVm(
     // @todo : after 2024-04-01 remove the fixmetadata options since the size computation is fixed
     if (mergedSize || (fixMetadata && fileSystemSize !== size)) {
       metadata.size = mergedSize ?? fileSystemSize ?? size
-
+
+      if (mergedSize) {
+        // all disks are now key disk
+        metadata.isVhdDifferencing = {}
+        for (const id of Object.values(metadata.vdis)) {
+          metadata.isVhdDifferencing[`${id}.vhd`] = false
+        }
+      }
       mustRegenerateCache = true
       try {
         await handler.writeFile(metadataPath, JSON.stringify(metadata), { flags: 'w' })

diff --git a/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs b/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs
@@ -161,7 +161,7 @@ export class IncrementalRemoteWriter extends MixinRemoteWriter(AbstractIncrement
     )
 
     metadataContent = {
-      differentialVhds,
+      isVhdDifferencing,
       jobId,
       mode: job.mode,
       scheduleId,