Skip to content

Commit

Permalink
fix(@xen-orchestra/backups): fix METHOD_NOT_ALLOWED when doing full b…
Browse files Browse the repository at this point in the history
…ackup

introduced by #7086
  • Loading branch information
fbeauchamp committed Oct 30, 2023
1 parent 1d7559d commit f70219a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion @xen-orchestra/backups/_runners/_vmRunners/FullXapi.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ export const FullXapi = class FullXapiVmBackupRunner extends AbstractXapi {
const vdis = await exportedVm.$getDisks()
let maxStreamLength = 1024 * 1024 // Ovf file and tar headers are a few KB, let's stay safe
for (const vdiRef of vdis) {
const vdi = await this._xapi.getRecord(vdiRef)
const vdi = await this._xapi.getRecord('VDI', vdiRef)

// at most the xva will take the physical usage of the disk
// the resulting stream can be smaller due to the smaller block size for xva than vhd, and compression of xcp-ng
maxStreamLength += vdi.physical_utilisation
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”
- [Netbox] Fix "The selected cluster is not assigned to this site" error [Forum#7887](https://xcp-ng.org/forum/topic/7887) (PR [#7124](https://github.com/vatesfr/xen-orchestra/pull/7124))
- [Backups] Fix "METHOD_UNKNOWN" during full backup [Forum#7894](https://xcp-ng.org/forum/topic/7894)

### Packages to release

Expand All @@ -29,6 +30,7 @@
<!--packages-start-->

- @xen-orchestra/backups patch
- xo-server-netbox patch

<!--packages-end-->

0 comments on commit f70219a

Please sign in to comment.