Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backup NG] Backup size on Restore page is way off #4316

Closed
mas90 opened this issue Jun 30, 2019 · 4 comments · Fixed by #4332
Closed

[Backup NG] Backup size on Restore page is way off #4316

mas90 opened this issue Jun 30, 2019 · 4 comments · Fixed by #4332

Comments

@mas90
Copy link
Contributor

mas90 commented Jun 30, 2019

Context

  • XO origin: the sources
  • Versions:

Expected behavior

Backup sizes shown on /backup-ng/restore should be accurate.

Current behavior

Backup size is very much higher than the actual disk usage, for many (not all) VMs.

screenshot-xo malc org uk-2019 06 30-17-27-05

One example: the UI shows that a VM's backups total 837.83 GiB (3 full + 17 delta backups). Clicking the delete button shows accurate sizes for the full backups (about 2 GiB each). Actual file size on disk is 31 GiB (of which 25 GiB are deltas).

Additionally, several of my VMs show the exact same backup size (837.83 GiB) even though the backups on disk are different sizes.

The backup remote is NFS + zfs; zfs has compression turned on so the actual disk usage is lower (18 GiB) in case that is throwing off the calculation somehow.

@Enishowk
Copy link
Contributor

Enishowk commented Jul 3, 2019

Hi, to be sure, you only have the display for full vm backup when you click on delete button. There is no display for the delta?

Because, currently we only display the total size of full vm backup on the column "size". Later, we will add to this total, those of delta backup

@mas90
Copy link
Contributor Author

mas90 commented Jul 3, 2019

Correct, I only see sizes for full backups:
screenshot-xo malc org uk-2019 07 03-20-17-44

Size column for that VM's backups currently reads 812.1 GiB -- if it is only counting full backups it should read 6.1 GiB.

@Enishowk
Copy link
Contributor

Enishowk commented Jul 4, 2019

Hi, I need more information like the json of your backups on this remote. Can you execute the command xo-cli backupNg.listVmBackups?

If you don't know xo-cli, it's a CLI tool that allows you to interact with xo-server: https://xen-orchestra.com/docs/xo-cli.html

Installation of xo-cli

sudo -s
npm i -g xo-cli

Connection to xo-server

xo-cli --register <XO URL> <XO user> <XO password>

Get id of your remote where the backup is located

xo-cli remote.getAll

The magic command

xo-cli backupNg.listVmBackups remotes=json:'["<remote ID>"]' > dump.json

Thanks for sending me the dump. :)
I'm available if you need help.

@mas90
Copy link
Contributor Author

mas90 commented Jul 4, 2019

Here's the backupNg.listVmBackups json: https://www.cl.cam.ac.uk/~mas90/tmp/dump.json

Thanks for investigating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants