Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store SortedTable params in URL #4542

Closed
julien-f opened this issue Sep 23, 2019 · 0 comments · Fixed by #4637
Closed

Store SortedTable params in URL #4542

julien-f opened this issue Sep 23, 2019 · 0 comments · Fixed by #4637
Assignees
@Rajaa-BARHTAOUI
Labels
comp: GUI 🎨 difficulty 0: trivial (minutes) severity 2: medium type: enhancement ✨
Milestone
19.22

Comments

@julien-f
Copy link
Member

We should check for all uses of SortedTable which are not using the stateUrlParam property and fix them.

How to find them:

git grep -A7 \<SortedTable packages/xo-web/src/xo-app/

I've noticed that the Backup / Overview page is not using it.
@julien-f julien-f added this to the [Frozen] 19.19 milestone Sep 23, 2019
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI modified the milestones: [Frozen] 19.19, 19.20 Sep 27, 2019
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI modified the milestones: 19.20, [Frozen] 19.21 Oct 11, 2019
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI modified the milestones: [Frozen] 19.21, 19.22 Oct 28, 2019
@julien-f julien-f changed the title Store SortedTables params in URL Store SortedTable params in URL Oct 30, 2019
Rajaa-BARHTAOUI added a commit that referenced this issue Oct 31, 2019
@Rajaa-BARHTAOUI
feat(xo-web): store sortedTable param in URL
9522771 
fixes #4542
@Rajaa-BARHTAOUI Rajaa-BARHTAOUI mentioned this issue Oct 31, 2019
Merged
8 tasks
Rajaa-BARHTAOUI added a commit that referenced this issue Oct 31, 2019
@Rajaa-BARHTAOUI
feat(xo-web): store SortedTable param in URL
3aba0f8 
fixes #4542
@badrAZ badrAZ mentioned this issue Nov 5, 2019
Merged
8 tasks
Rajaa-BARHTAOUI added a commit that referenced this issue Nov 8, 2019
@Rajaa-BARHTAOUI
feat(xo-web): store SortedTable param in URL
edb0733 
fixes #4542
Rajaa-BARHTAOUI added a commit that referenced this issue Nov 18, 2019
@Rajaa-BARHTAOUI
feat(xo-web): store SortedTable param in URL
2155b33 
fixes #4542
pdonias pushed a commit that referenced this issue Nov 19, 2019
@Rajaa-BARHTAOUI @pdonias
feat(xo-web): store SortedTable param in URL (#4637)
fe7f74e 
Fixes #4542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI

Labels
comp: GUI 🎨 difficulty 0: trivial (minutes) severity 2: medium type: enhancement ✨
Projects
None yet
Milestone
19.22
Development

Successfully merging a pull request may close this issue.

feat(xo-web): store SortedTable param in URL vatesfr/xen-orchestra
2 participants
@julien-f @Rajaa-BARHTAOUI