Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display micro and build version of the guest tools #5680

Closed
stormi opened this issue Mar 18, 2021 · 1 comment · Fixed by #5691
Closed

Display micro and build version of the guest tools #5680

stormi opened this issue Mar 18, 2021 · 1 comment · Fixed by #5691

Comments

@stormi
Copy link
Collaborator

stormi commented Mar 18, 2021

The version of the guest tools currently displayed in the General and the Advanced tabs of a VM only contains major and minor numbers.

It would be good to have the full version in the Advanced tab, and probably in the General tab too to be consistent.

The new version displayed would then be major.minor.micro-build (dash before build because it's not exactly part of the upstream version, but is still useful information especially in XCP-ng context where we'll use that number to identify the tools version more precisely).

@stormi
Copy link
Collaborator Author

stormi commented Mar 18, 2021

It would be changed here:

pvDriversVersion: hasPvVersion ? `${major}.${minor}` : undefined,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant