Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on sr.probeNfsExists #5991

Closed
Danp2 opened this issue Nov 9, 2021 · 1 comment · Fixed by #6137
Closed

Error on sr.probeNfsExists #5991

Danp2 opened this issue Nov 9, 2021 · 1 comment · Fixed by #6137

Comments

@Danp2
Copy link
Collaborator

Danp2 commented Nov 9, 2021

Describe the bug
XO generates an error during the creation of an NFS SR if you chose a path from the dropdown and then switch back to the default of "No selected value"

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Created a new SR'
  2. Fill in the form
  3. Click the search button to fill the dropdown
  4. Select one of the valid paths in the dropdown
  5. Select the original "No selected value" entry from path dropdown
  6. See error

Expected behavior
XO shouldn't attempt to probe the NFS server when the user picks "No selected value" from the dropdown

Log

sr.probeNfsExists
{
  "host": "dfd93f0e-08f7-4cac-8f9c-1eb698cd0c5c",
  "server": "192.168.1.65",
  "serverPath": "No selected value"
}
{
  "code": "SR_BACKEND_FAILURE_103",
  "params": [
    "",
    "The serverpath argument is not valid [opterr=serverpath is No selected value]",
    ""
  ],
  "call": {
    "method": "SR.probe",
    "params": [
      "OpaqueRef:e2781353-8cd6-0938-108d-1b7933d4c739",
      {
        "server": "192.168.1.65",
        "serverpath": "No selected value"
      },
      "nfs",
      {}
    ]
  },
  "message": "SR_BACKEND_FAILURE_103(, The serverpath argument is not valid [opterr=serverpath is No selected value], )",
  "name": "XapiError",
  "stack": "XapiError: SR_BACKEND_FAILURE_103(, The serverpath argument is not valid [opterr=serverpath is No selected value], )
    at Function.wrap (/opt/xen-orchestra/packages/xen-api/src/_XapiError.js:16:12)
    at /opt/xen-orchestra/packages/xen-api/src/transports/json-rpc.js:41:27
    at AsyncResource.runInAsyncScope (node:async_hooks:199:9)
    at cb (/opt/xen-orchestra/node_modules/bluebird/js/release/util.js:355:42)
    at tryCatcher (/opt/xen-orchestra/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/opt/xen-orchestra/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/opt/xen-orchestra/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/opt/xen-orchestra/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/opt/xen-orchestra/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (node:internal/timers:464:21)
    at process.topLevelDomainCallback (node:domain:152:15)
    at process.callbackTrampoline (node:internal/async_hooks:128:24)"
}

Desktop (please complete the following information):

  • xo-server: 5.83.0
  • xo-web: 5.88.0
  • hypervisor: XCP-ng 8.2.0
@julien-f
Copy link
Member

julien-f commented Mar 1, 2022

The serverPath is incorrect, the UI should not send that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants