Add a warning modal when enabling "Windows update tools"

[olivierlambert]

Context

If you use XCP-ng tools in your Windows VM, and then decide to enable "Windows Update tools" in VM view/advanced, this will break all the PV drivers instantly.

It's documented in XCP-ng doc, but there's no warning in XO UI

Solution

If you enable this, we should open a model, telling, for example:

⚠️ If you enable this feature while your VM is using XCP-ng tools and NOT Citrix tools, this will simply break all the virtual drivers (network, storage…). Are you sure you want to enable it? Double check you are using the Citrix tools before doing this.

Cancel / Confirm

[Fohdeesha]

I think in the modal we should also make it clear it only installs PV drivers, and you will still be left without a management agent

[Darkbeldin]

I agree with @Fohdeesha with the management agent warning.

[olivierlambert]

@Fohdeesha could you write the entire text you'd like to see in that very modal?

[Fohdeesha]

Enabling this will allow the VM to automatically install Citrix PV drivers from windows update. This only includes drivers, the Citrix management agent must still be separately installed. If you have previously installed XCP-ng tools instead of Citrix tools, this option will break your VM.

too long?

[olivierlambert]

Nah that's fine to me :)