feat(xo-web/Backup NG/logs): display the export type #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrAZ
changed the title
julien-f
requested changes
Jun 4, 2018
julien-f
approved these changes
Jun 6, 2018
| ).then(result => ({ | ||
| size: sumBy(result, 'size'), | ||
| isFull: some(result, { isDelta: false }), | ||
| })) |
There was a problem hiding this comment.
This should be implemented for CR as well.
IMHO, you should do it before the waitAll.
julien-f
requested changes
Jun 7, 2018
| @@ -1018,12 +1018,14 @@ export default class BackupNg { | |||
| } | |||
| })() | |||
|
|
|||
| const getIsDelta = vdi => vdi.other_config['xo:base_delta'] !== undefined | |||
There was a problem hiding this comment.
This function is not a closure, move it outside of this scope.
| @@ -1018,12 +1018,14 @@ export default class BackupNg { | |||
| } | |||
| })() | |||
|
|
|||
| const getIsDelta = vdi => vdi.other_config['xo:base_delta'] !== undefined | |||
| const isFull = some(deltaExport.vdis, vdi => !getIsDelta(vdi)) | |||
There was a problem hiding this comment.
Avoid creating a wrapper around getIsDelta.
julien-f
approved these changes
Jun 7, 2018
|
Please check all boxes if the appropriate action is done or if not relevant. |
badrAZ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2711
Check list
Fixes #007)Process
WiP:(Work in Progress) if not ready to be mergedList of packages to release
Screenshots