Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/backup-ng/new): make the smart mode's toggle more visible #3255

Merged
merged 3 commits into from Aug 6, 2018
Merged

feat(xo-web/backup-ng/new): make the smart mode's toggle more visible #3255

merged 3 commits into from Aug 6, 2018

Conversation

badrAZ
Copy link
Contributor

@badrAZ badrAZ commented Aug 1, 2018 •
edited

See #2711

Screenshot

image

image

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

@badrAZ badrAZ self-assigned this Aug 1, 2018
@badrAZ badrAZ requested a review from pdonias August 1, 2018 14:16
@julien-f julien-f mentioned this pull request Aug 2, 2018
Closed
40 tasks
@badrAZ
Copy link
Contributor Author

badrAZ commented Aug 3, 2018

Note: This PR can be merged after merging the PR #3258

@badrAZ badrAZ changed the base branch from master to actionButton-iconColor August 3, 2018 10:47
@badrAZ badrAZ changed the base branch from actionButton-iconColor to master August 3, 2018 11:21
@badrAZ badrAZ changed the base branch from master to actionButton-iconColor August 3, 2018 11:21
@badrAZ badrAZ mentioned this pull request Aug 3, 2018
Merged
4 tasks
pdonias pushed a commit that referenced this pull request Aug 6, 2018
@badrAZ @pdonias
feat(xo-web/ActionButton): ability to set the icon's color (#3258)
a58a9a9 
See PR: #3255
@pdonias pdonias merged commit 38e1c08 into actionButton-iconColor Aug 6, 2018
@pdonias pdonias deleted the improveSmartToggle branch August 6, 2018 09:27
@badrAZ badrAZ restored the improveSmartToggle branch August 6, 2018 09:29
badrAZ added a commit that referenced this pull request Aug 6, 2018
@badrAZ
Revert "feat(xo-web/backup-ng/new): make the smart mode's toggle more…
69228f9 
… visible (#3255)"

This reverts commit 38e1c08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

Assignees

@badrAZ badrAZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@badrAZ @pdonias